Skip to content

Fixed incorrect datepicker icon position in admin panel#18627

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
rogyar:wrong-datepicker-position-fix
Oct 25, 2018
Merged

Fixed incorrect datepicker icon position in admin panel#18627
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
rogyar:wrong-datepicker-position-fix

Conversation

@rogyar
Copy link
Contributor

@rogyar rogyar commented Oct 15, 2018

Description (*)

The datepicker icons position in the admin panel is incorrect after porting a fix that is not actual for Magento 2.2+ (#16776).

As result, we have the following position instead of the correct one:

image

This PR fixes the icons position

Fixed Issues (if relevant)

  1. Calendar Icon is displaced at the Backend #18605 : Calendar Icon is displaced at the Backend

Manual testing scenarios (*)

  1. Login to the admin panel
  2. Create a new product or edit an existing one
  3. Check the "Set Product as New From" attribute

The icons possition should be correct

(Thank you @larsroettig for providing the detailed information)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend Release Line: 2.3 labels Oct 15, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 15, 2018

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@larsroettig larsroettig self-requested a review October 17, 2018 10:25
@larsroettig
Copy link
Member

larsroettig commented Oct 17, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 17, 2018

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 17, 2018

Hi @larsroettig, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18627//admin
Login: admin Password: 123123q

@larsroettig larsroettig self-assigned this Oct 17, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 17, 2018

Hi @larsroettig, thank you for the review.
ENGCOM-3209 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Oct 25, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 3f0e9a4 into magento:2.3-develop Oct 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 25, 2018
ENGCOM-3209: Fixed incorrect datepicker icon position in admin panel #…
9ac1a81 
…18627
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 25, 2018

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@ghost ghost mentioned this pull request Jan 8, 2019
Closed
@Ctucker9233
Copy link

Ctucker9233 commented Feb 8, 2019

@magento-engcom-team Is there a backport for 2.2? I see the same behavior.

@hostep hostep mentioned this pull request Sep 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsroettig larsroettig larsroettig approved these changes

Assignees

@larsroettig larsroettig

Labels

Area: Design/Frontend Award: bug fix Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@rogyar @magento-engcom-team @larsroettig @Ctucker9233